gtk4.git
6 years agowin32: Stop using gdk_surface_show
Matthias Clasen [Mon, 9 Mar 2020 17:25:06 +0000 (10:25 -0700)]
win32: Stop using gdk_surface_show

6 years agobroadway: Stop using gdk_surface_show
Matthias Clasen [Mon, 9 Mar 2020 17:24:52 +0000 (10:24 -0700)]
broadway: Stop using gdk_surface_show

6 years agowayland: Drop dead code
Matthias Clasen [Mon, 9 Mar 2020 17:24:30 +0000 (10:24 -0700)]
wayland: Drop dead code

6 years agox11: Stop using gdk_surface_show
Matthias Clasen [Mon, 9 Mar 2020 17:20:13 +0000 (10:20 -0700)]
x11: Stop using gdk_surface_show

6 years agogdk: Drop surface-type
Matthias Clasen [Mon, 9 Mar 2020 15:22:55 +0000 (08:22 -0700)]
gdk: Drop surface-type

We have interfaces for surface subtypes now.

6 years agowayland: Stop using surface-type
Matthias Clasen [Mon, 9 Mar 2020 15:04:19 +0000 (08:04 -0700)]
wayland: Stop using surface-type

6 years agox11: Stop using surface-type
Matthias Clasen [Mon, 9 Mar 2020 15:00:51 +0000 (08:00 -0700)]
x11: Stop using surface-type

6 years agobroadway: Stop using surface type
Matthias Clasen [Mon, 9 Mar 2020 15:00:26 +0000 (08:00 -0700)]
broadway: Stop using surface type

6 years agox11: Stop using gdk_surface_get_surface_type
Matthias Clasen [Sun, 8 Mar 2020 20:38:03 +0000 (13:38 -0700)]
x11: Stop using gdk_surface_get_surface_type

6 years agowayland: Stop using surface types
Matthias Clasen [Sun, 8 Mar 2020 20:37:13 +0000 (13:37 -0700)]
wayland: Stop using surface types

6 years agosurface: Stop using surface types
Matthias Clasen [Mon, 9 Mar 2020 20:00:08 +0000 (13:00 -0700)]
surface: Stop using surface types

6 years agosurface: Don't implement subtypes in the frontend
Matthias Clasen [Sun, 8 Mar 2020 16:21:18 +0000 (09:21 -0700)]
surface: Don't implement subtypes in the frontend

These are now provided by the backend.

6 years agox11: Only use state of toplevels
Matthias Clasen [Sun, 8 Mar 2020 16:20:07 +0000 (09:20 -0700)]
x11: Only use state of toplevels

Other surface subtypes don't have that property.

6 years agobroadway: Implement GdkPopup, GdkToplevel and GdkDragSurface
Matthias Clasen [Sat, 7 Mar 2020 22:11:16 +0000 (14:11 -0800)]
broadway: Implement GdkPopup, GdkToplevel and GdkDragSurface

Make subclasses of GdkX11Surface that implement these
interfaces.

6 years agox11: Implement GdkPopup, GdkToplevel and GdkDragSurface
Matthias Clasen [Sat, 7 Mar 2020 21:59:24 +0000 (13:59 -0800)]
x11: Implement GdkPopup, GdkToplevel and GdkDragSurface

Make subclasses of GdkX11Surface that implement these
interfaces.

6 years agowayland: Implement GdkPopup, GdkToplevel and GdkDragSurface
Matthias Clasen [Sat, 7 Mar 2020 21:08:43 +0000 (13:08 -0800)]
wayland: Implement GdkPopup, GdkToplevel and GdkDragSurface

Make subclasses of GdkWaylandSurface that implement these
interfaces.

6 years agoDrop gdk_surface_set_opacity
Matthias Clasen [Wed, 4 Mar 2020 17:39:03 +0000 (09:39 -0800)]
Drop gdk_surface_set_opacity

6 years agox11: Stop using gdk_surface_set_opacity
Matthias Clasen [Wed, 4 Mar 2020 17:38:27 +0000 (09:38 -0800)]
x11: Stop using gdk_surface_set_opacity

We can just use the backend api directly.

6 years agowidget: Stop using gdk_surface_set_opacity
Matthias Clasen [Wed, 4 Mar 2020 17:38:01 +0000 (09:38 -0800)]
widget: Stop using gdk_surface_set_opacity

6 years agoDrop gdk_surface_show and gdk_surface_resize
Matthias Clasen [Wed, 4 Mar 2020 00:03:39 +0000 (16:03 -0800)]
Drop gdk_surface_show and gdk_surface_resize

We can now use GdkDragIcon api for the last cases
where this was used.

6 years agogtkdragicon: Use drag surface api
Matthias Clasen [Tue, 3 Mar 2020 23:56:23 +0000 (15:56 -0800)]
gtkdragicon: Use drag surface api

6 years agoAdd a GdkDragSurface interface
Matthias Clasen [Tue, 3 Mar 2020 23:55:45 +0000 (15:55 -0800)]
Add a GdkDragSurface interface

This will provide functionality specific to drag icons.

6 years agosurface: Drop redundant toplevel api
Matthias Clasen [Sat, 29 Feb 2020 17:05:42 +0000 (12:05 -0500)]
surface: Drop redundant toplevel api

The toplevel functionality to keep is moving to
GdkToplevel, and unused functions can go.

6 years agodocs: Stop using gdk_surface_get_decorations
Matthias Clasen [Tue, 3 Mar 2020 20:25:41 +0000 (12:25 -0800)]
docs: Stop using gdk_surface_get_decorations

6 years agotestgtk: Stop setting decorations and functions
Matthias Clasen [Thu, 5 Mar 2020 18:10:29 +0000 (10:10 -0800)]
testgtk: Stop setting decorations and functions

6 years agotests: Stop using gdk_surface_fullscreen
Matthias Clasen [Sun, 1 Mar 2020 18:10:39 +0000 (10:10 -0800)]
tests: Stop using gdk_surface_fullscreen

6 years agotestgtk: Stop using gdk_surface_set_icon_name
Matthias Clasen [Sun, 1 Mar 2020 17:32:50 +0000 (12:32 -0500)]
testgtk: Stop using gdk_surface_set_icon_name

Its not useful api, and will disappear.

6 years agowayland: Stop using gdk_surface_set_title
Matthias Clasen [Sun, 1 Mar 2020 17:31:26 +0000 (12:31 -0500)]
wayland: Stop using gdk_surface_set_title

Directly call the backend function for this, and for
gdk_surface_set_transient_for.

6 years agotestgtk: Stop using gdk_surface_get_state
Matthias Clasen [Sun, 1 Mar 2020 17:41:25 +0000 (12:41 -0500)]
testgtk: Stop using gdk_surface_get_state

6 years agodemo: stop using gdk_surface_get_state
Matthias Clasen [Sun, 1 Mar 2020 01:44:19 +0000 (20:44 -0500)]
demo: stop using gdk_surface_get_state

6 years agoa11y: Stop using gdk_surface_get_state
Matthias Clasen [Sun, 1 Mar 2020 01:44:02 +0000 (20:44 -0500)]
a11y: Stop using gdk_surface_get_state

6 years agox11: Stop using gdk_surface_get_state
Matthias Clasen [Sun, 1 Mar 2020 01:43:34 +0000 (20:43 -0500)]
x11: Stop using gdk_surface_get_state

All the surfaces we are dealing with here are toplevels.

6 years agogtk: use toplevel state getter
Matthias Clasen [Sun, 1 Mar 2020 01:32:15 +0000 (20:32 -0500)]
gtk: use toplevel state getter

6 years agowindow: Use GdkToplevel
Matthias Clasen [Sat, 29 Feb 2020 11:53:24 +0000 (06:53 -0500)]
window: Use GdkToplevel

6 years agoIntroduce GdkToplevel
Matthias Clasen [Sat, 29 Feb 2020 15:07:43 +0000 (10:07 -0500)]
Introduce GdkToplevel

This is a new interface for toplevel surfaces.

6 years agoIntroduce GdkToplevelLayout
Matthias Clasen [Sat, 29 Feb 2020 15:31:22 +0000 (10:31 -0500)]
Introduce GdkToplevelLayout

This will be used in a new GdkTopleve interface in
the near future.

6 years agotestsuite: Stop using type-hints
Matthias Clasen [Wed, 11 Mar 2020 22:12:41 +0000 (18:12 -0400)]
testsuite: Stop using type-hints

6 years agowindow: Drop type hints
Matthias Clasen [Fri, 6 Mar 2020 20:57:55 +0000 (12:57 -0800)]
window: Drop type hints

6 years agox11: Set type hints based on surface type
Matthias Clasen [Sat, 7 Mar 2020 17:07:53 +0000 (09:07 -0800)]
x11: Set type hints based on surface type

Set the ewmh type hints based on the surface type and
transient parent, instead of taking it from the type hint.

6 years agoStop setting type hints for dialogs
Matthias Clasen [Fri, 6 Mar 2020 20:57:37 +0000 (12:57 -0800)]
Stop setting type hints for dialogs

6 years agoshortcutswindow: Stop setting type hints
Matthias Clasen [Fri, 6 Mar 2020 20:55:28 +0000 (12:55 -0800)]
shortcutswindow: Stop setting type hints

6 years agoheaderbar: Stop looking at type hints
Matthias Clasen [Fri, 6 Mar 2020 20:55:15 +0000 (12:55 -0800)]
headerbar: Stop looking at type hints

6 years agotestsuite: Stop using type-hint
Matthias Clasen [Wed, 11 Mar 2020 21:44:21 +0000 (17:44 -0400)]
testsuite: Stop using type-hint

6 years agoa11y: Stop using type hints
Matthias Clasen [Fri, 6 Mar 2020 20:55:01 +0000 (12:55 -0800)]
a11y: Stop using type hints

6 years agowayland: Stop tracking orphan dialogs
Matthias Clasen [Fri, 6 Mar 2020 20:38:13 +0000 (12:38 -0800)]
wayland: Stop tracking orphan dialogs

Wayland has no concept of transient-for-group. If we want to
support that, add proper proper protocol for it, don't hack it
in this like.

6 years agosurface: Rename gdk_surface_input_shape_combine_region
Matthias Clasen [Sun, 1 Mar 2020 19:29:06 +0000 (11:29 -0800)]
surface: Rename gdk_surface_input_shape_combine_region

There is no shape combining going on anymore, so
call this just gdk_surface_set_input_region, and
remove the offset arguments too. All callers pass
0 anyway.

Update all callers and implementations.

6 years agox11: Stop using gdk_surface_maximize
Matthias Clasen [Sat, 29 Feb 2020 18:11:53 +0000 (13:11 -0500)]
x11: Stop using gdk_surface_maximize

Just use the backend function directly.

6 years agox11: Stop using gdk_surface_set_geometry_hints
Matthias Clasen [Sat, 29 Feb 2020 18:06:43 +0000 (13:06 -0500)]
x11: Stop using gdk_surface_set_geometry_hints

Just use the backend function directly.

6 years agowayland: Stop using gdk_surface_set_geometry_hints
Matthias Clasen [Sat, 29 Feb 2020 18:06:22 +0000 (13:06 -0500)]
wayland: Stop using gdk_surface_set_geometry_hints

Just use the backend function directly.

6 years agoinspector: Stop raising and lowering windows
Matthias Clasen [Sat, 29 Feb 2020 17:55:13 +0000 (12:55 -0500)]
inspector: Stop raising and lowering windows

We should always be composited, so this should not
matter in practice.

6 years agox11: Stop using gdk_surface_raise
Matthias Clasen [Sat, 29 Feb 2020 17:54:24 +0000 (12:54 -0500)]
x11: Stop using gdk_surface_raise

Avoid a vfunc roundtrip and just use the backend
implementation directly.

6 years agobroadway: Stop using gdk_surface_raise
Matthias Clasen [Sat, 29 Feb 2020 17:53:26 +0000 (12:53 -0500)]
broadway: Stop using gdk_surface_raise

We don't implement this anyway. Add a shortcut
to the backend function in case we ever do.

6 years agox11: Stop abusing type hints for dnd
Matthias Clasen [Sat, 29 Feb 2020 17:37:51 +0000 (12:37 -0500)]
x11: Stop abusing type hints for dnd

Nothing in GDK depends on this being set, so just
don't do it.

6 years agowayland: Stop abusing type hints
Matthias Clasen [Sat, 29 Feb 2020 17:25:51 +0000 (12:25 -0500)]
wayland: Stop abusing type hints

Instead of misusing window type hints, introduce
a private flag for drag surfaces.

6 years agosurface: Drop popup api
Matthias Clasen [Wed, 11 Mar 2020 05:15:43 +0000 (01:15 -0400)]
surface: Drop popup api

We have the GdkPopup interface now.

6 years agotooltip: Use GdkPopup
Matthias Clasen [Sat, 29 Feb 2020 14:46:13 +0000 (09:46 -0500)]
tooltip: Use GdkPopup

6 years agopopover: Use GdkPopup
Matthias Clasen [Sat, 29 Feb 2020 14:44:05 +0000 (09:44 -0500)]
popover: Use GdkPopup

6 years agosurface: Implement GdkPopup
Matthias Clasen [Sat, 29 Feb 2020 14:34:11 +0000 (09:34 -0500)]
surface: Implement GdkPopup

This is not quite right, and only temporary, since
it makes GDK_IS_POPUP (surface) true for every surface.

Eventually, the implementation will be moved to the
backends.

6 years agoIntroduce GdkPopup
Matthias Clasen [Sat, 29 Feb 2020 14:17:02 +0000 (09:17 -0500)]
Introduce GdkPopup

This is a new interface for popup surfaces.

6 years agopopuplayout: Add docs
Matthias Clasen [Mon, 9 Mar 2020 20:36:38 +0000 (13:36 -0700)]
popuplayout: Add docs

6 years agoMove GdkSurface autocleanup declaration
Matthias Clasen [Sat, 29 Feb 2020 14:17:23 +0000 (09:17 -0500)]
Move GdkSurface autocleanup declaration

We need this available after including gdksurface.h.

6 years agowayland: Stop calling frontend surface api
Matthias Clasen [Sat, 29 Feb 2020 14:51:26 +0000 (09:51 -0500)]
wayland: Stop calling frontend surface api

This is an unnecessary vfunc roundtrip, and the
frontend api is going away shortly.

6 years agoSimplify surface move/drag api
Matthias Clasen [Sat, 29 Feb 2020 16:25:32 +0000 (11:25 -0500)]
Simplify surface move/drag api

Drop the with_device variants, and always pass a device.

6 years agotestsuite: Update a11y test output
Matthias Clasen [Wed, 11 Mar 2020 20:37:32 +0000 (16:37 -0400)]
testsuite: Update a11y test output

6 years agotestsuite: Stop using GtkSpinner::active
Matthias Clasen [Wed, 11 Mar 2020 20:37:10 +0000 (16:37 -0400)]
testsuite: Stop using GtkSpinner::active

This property was renamed to ::spinning.

6 years agoDrop gtk_window_begin_move/resize_drag
Matthias Clasen [Sat, 29 Feb 2020 16:14:01 +0000 (11:14 -0500)]
Drop gtk_window_begin_move/resize_drag

These are just simple wrappers around GdkSurface
api, and we don't need them.

6 years agodisable popover test
Matthias Clasen [Wed, 11 Mar 2020 20:41:02 +0000 (16:41 -0400)]
disable popover test

This is failing atm

6 years agoUpdate Japanese translation
sicklylife [Mon, 9 Mar 2020 12:49:58 +0000 (12:49 +0000)]
Update Japanese translation

6 years agoUpdate Japanese translation
sicklylife [Mon, 9 Mar 2020 12:36:08 +0000 (12:36 +0000)]
Update Japanese translation

6 years agoMerge branch 'master' into 'master'
Matthias Clasen [Fri, 6 Mar 2020 18:02:06 +0000 (18:02 +0000)]
Merge branch 'master' into 'master'

builder-tool: rename show-close-button to show-title-buttons

See merge request GNOME/gtk!1497

6 years agoMerge branch 'wip/tbaederr/fallthrough' into 'master'
Alexander Larsson [Fri, 6 Mar 2020 10:48:16 +0000 (10:48 +0000)]
Merge branch 'wip/tbaederr/fallthrough' into 'master'

Replace fallthrough comments with G_GNUC_FALLTHROUGH

See merge request GNOME/gtk!1505

6 years agoReplace fallthrough comments with G_GNUC_FALLTHROUGH
Timm Bäder [Fri, 6 Mar 2020 07:32:21 +0000 (08:32 +0100)]
Replace fallthrough comments with G_GNUC_FALLTHROUGH

6 years agoMerge branch 'wip/otte/for-master' into 'master'
Benjamin Otte [Fri, 6 Mar 2020 05:48:56 +0000 (05:48 +0000)]
Merge branch 'wip/otte/for-master' into 'master'

Wip/otte/for master

See merge request GNOME/gtk!1504

6 years agostack: Make static analyzer happy
Benjamin Otte [Fri, 6 Mar 2020 04:56:29 +0000 (05:56 +0100)]
stack: Make static analyzer happy

6 years agopathbar: Don't do the same thing twice.
Benjamin Otte [Fri, 6 Mar 2020 04:53:20 +0000 (05:53 +0100)]
pathbar: Don't do the same thing twice.

Don't do the same thing twice.

6 years agoreftest: Plug memleak
Benjamin Otte [Fri, 6 Mar 2020 04:52:44 +0000 (05:52 +0100)]
reftest: Plug memleak

6 years agotreeview: Don't assign value twice.
Benjamin Otte [Fri, 6 Mar 2020 04:51:37 +0000 (05:51 +0100)]
treeview: Don't assign value twice.

6 years agocellarea: Be very clear
Benjamin Otte [Fri, 6 Mar 2020 04:50:35 +0000 (05:50 +0100)]
cellarea: Be very clear

The static analyzer needs to know we absolutely DO NOT want to use this
return value.

6 years agobuilder-tool: Don't allow property to be both resize and shrink
Benjamin Otte [Fri, 6 Mar 2020 04:29:46 +0000 (05:29 +0100)]
builder-tool: Don't allow property to be both resize and shrink

Otherwise builder-tool crashes when you do

  <property name="shrink" name="resize">1</property>

Thanks to the static analyzer for figuring that one out.

6 years agoapplicationaccels: Use g_renew()
Benjamin Otte [Fri, 6 Mar 2020 04:06:25 +0000 (05:06 +0100)]
applicationaccels: Use g_renew()

6 years agoliststore: Fix gtk_list_store_iter_is_valid()
Benjamin Otte [Fri, 6 Mar 2020 04:03:45 +0000 (05:03 +0100)]
liststore: Fix gtk_list_store_iter_is_valid()

The iter may be invalid, so we may not read from it.

testsuite/gtk/treemodel tests this and valgrind is shouting about it,
but it never crashed until I just ran it...

This bug is from 2004 and the test is from 2007. I guess invalid memory
accesses don't get caught by CI much.

6 years agotesttreeview: Fix 19 year old use-after-free
Benjamin Otte [Fri, 6 Mar 2020 04:01:01 +0000 (05:01 +0100)]
testtreeview: Fix 19 year old use-after-free

6 years agotreepath: Use g_renew()
Benjamin Otte [Fri, 6 Mar 2020 03:31:30 +0000 (04:31 +0100)]
treepath: Use g_renew()

6 years agotestsuite: Avoid passing NULL to strcmp()
Benjamin Otte [Fri, 6 Mar 2020 03:31:08 +0000 (04:31 +0100)]
testsuite: Avoid passing NULL to strcmp()

Use g_strcmp0() instead.

6 years agotreeview: Don't initialize variable twice
Benjamin Otte [Fri, 6 Mar 2020 03:24:30 +0000 (04:24 +0100)]
treeview: Don't initialize variable twice

6 years agoMerge branch 'wip/otte/for-master' into 'master'
Benjamin Otte [Thu, 5 Mar 2020 18:20:36 +0000 (18:20 +0000)]
Merge branch 'wip/otte/for-master' into 'master'

Wip/otte/for master

See merge request GNOME/gtk!1502

6 years agobuild: Add -Wnull-dereference
Benjamin Otte [Thu, 5 Mar 2020 06:02:24 +0000 (07:02 +0100)]
build: Add -Wnull-dereference

Sprinkle various g_assert() around the code where gcc cannot figure out
on its own that a variable is not NULL and too much refactoring would be
needed to make it do that.

Also fix usage of g_assert_nonnull(x) to use g_assert(x) because the
first is not marked as G_GNUC_NORETURN because of course GTester
supports not aborting on aborts.

6 years agoicontheme: Remove unused parameter
Benjamin Otte [Thu, 5 Mar 2020 06:56:01 +0000 (07:56 +0100)]
icontheme: Remove unused parameter

It's only ever set to NULL (and then dereferenced, too)

6 years agotreerbtree: Use for loops
Benjamin Otte [Thu, 5 Mar 2020 05:58:44 +0000 (06:58 +0100)]
treerbtree: Use for loops

Makes the code more readable.
Also does the NULL check for the initial element, which was misisng
before.

6 years agonotebook: Don't crash on drags not coming from a notebook
Benjamin Otte [Thu, 5 Mar 2020 05:58:12 +0000 (06:58 +0100)]
notebook: Don't crash on drags not coming from a notebook

6 years agoicontheme: Don't crash on icon lookup failure
Benjamin Otte [Thu, 5 Mar 2020 05:57:44 +0000 (06:57 +0100)]
icontheme: Don't crash on icon lookup failure

6 years agodevice: Handle missing axis
Benjamin Otte [Thu, 5 Mar 2020 05:57:26 +0000 (06:57 +0100)]
device: Handle missing axis

6 years agorbtree: Simplify macros
Benjamin Otte [Thu, 5 Mar 2020 05:53:26 +0000 (06:53 +0100)]
rbtree: Simplify macros

* NODE_FROM_POINTER() can not be NULL

* shuffle NODE_TO_POINTER() code for readability so that the NULL check
  is on the outside and not the cast

6 years agorbtree: Simplify code
Benjamin Otte [Thu, 5 Mar 2020 05:51:32 +0000 (06:51 +0100)]
rbtree: Simplify code

This makes it easier to understand for gcc (and hopefully humans, too)
that by rotating we essentially just swap `node` and `p`.

6 years agobuild: Add more useful warning flags
Benjamin Otte [Thu, 5 Mar 2020 02:58:29 +0000 (03:58 +0100)]
build: Add more useful warning flags

I found those on the interwebs and decided they are useful.

6 years agomountoperation-x11: Fix copy/paste thinko
Benjamin Otte [Thu, 5 Mar 2020 05:14:58 +0000 (06:14 +0100)]
mountoperation-x11: Fix copy/paste thinko

6 years agotests: Add a test for changing the hovered widget
Benjamin Otte [Wed, 4 Mar 2020 00:24:32 +0000 (01:24 +0100)]
tests: Add a test for changing the hovered widget

The add/remove one crashes after a few enter/leave events.

6 years agoimcontextwayland: Fix copy/paste error
Benjamin Otte [Thu, 5 Mar 2020 02:57:53 +0000 (03:57 +0100)]
imcontextwayland: Fix copy/paste error

6 years agotextview: Fix copy/paste error
Benjamin Otte [Thu, 5 Mar 2020 02:57:24 +0000 (03:57 +0100)]
textview: Fix copy/paste error

6 years agoMerge branch 'patch-1' into 'master'
Timm Bäder [Wed, 4 Mar 2020 11:01:30 +0000 (11:01 +0000)]
Merge branch 'patch-1' into 'master'

gdk_monitor_get_model: Fix a typo in the function documentation

See merge request GNOME/gtk!1499